Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested targets to CacheContext #9569

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Dec 21, 2023

Fixes #9554

As usual, the Visual Studio code path is a bit icky. It basically just uses the target names of whatever the first request it receives which uses a given plugin. In practice this is fine since VS uses the same target across all projects depending on scenario (Build, Rebuild, Clean, etc.).

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rokonec rokonec merged commit 5ba78b7 into dotnet:main Jan 3, 2024
8 checks passed
@dfederm dfederm deleted the cachecontext-targetnames branch January 3, 2024 17:19
@rainersigwald
Copy link
Member

/backport to vs17.9

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Started backporting to vs17.9: https://github.com/dotnet/msbuild/actions/runs/7427132481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Project cache plugins are not provided the entry targets
4 participants